search

expo / expo-three

Utilities for using THREE.js on Expo
MIT License
711 stars 87 forks source link

Updated README to support newer versions of Expo SDK #300

Open andrija29 opened 4 months ago

andrija29 commented 4 months ago

Reason

Previous README.md file's section about updating metro configuration was not working for newer versions of the Expo SDK.

Explanation

Expo uses it's internal metro configuration that get's overridden when you have .metro.config.js file in your project root folder. With the code from the previous README.md file Expo couldn't bundle the app correctly because it was missing parts of the Expo's default metro configuration. Update was made according to the official Expo documentation found here: https://docs.expo.dev/guides/customizing-metro/

markrickert commented 3 months ago

@andrija29 Check out my upgrades in #301. This PR should be merged along with that one.

andrija29 commented 3 months ago

@andrija29 Check out my upgrades in #301. This PR should be merged along with that one.

Great work guys! Will merge it as soon as this gets approved and your PR gets merged.