search

expo / expo-webpack-integrations

Packages used to integrate Expo in Webpack-based projects.
8 stars 1 forks source link

expo-pwa generate urls with backslashes on Windows #13

Open jer-sen opened 1 year ago

jer-sen commented 1 year ago

Summary

expo-pwa generate urls with backslashes on Windows in index.html

Environment

  expo-env-info 1.0.5 environment info:
    System:
      OS: Windows 10 10.0.19045
    Binaries:
      Node: 18.16.0 - C:\Program Files\nodejs\node.EXE
      Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD  
      npm: 9.6.7 - C:\Program Files\nodejs\npm.CMD    
    IDEs:
      Android Studio: AI-222.4459.24.2221.9971841

Please specify your device/emulator/simulator platform, model and version

NA

Error output

<link rel="icon" type="image/png" sizes="16x16" href="\favicon-16.png">

Reproducible demo or steps to reproduce from a blank project

path.join should not be used in joinUrlPath here https://github.com/expo/expo-cli/blob/6fca69c74e3c70c8ee45da427e8075a1a3752229/packages/pwa/src/index.ts#LL14C1-L14C1