expo-modules-autolinking is wanted as a peer dependency but is failing expo-doctor

ChromeQ commented 7 months ago

Summary

With a new or existing expo app notice there are no warnings with yarn install.

Add expo-splash-screen as a dependency. Notice the warning about missing peer dependency.

Expo doctor is happy so far.

Add expo-modules-autolinking as a dependency. Notice the warning about missing peer dependency is gone.

Expo doctor is no longer happy and breaks my CI.

Yes I know I can live with a warning as it doesn't seem to break anything, but it would be nice to get this resolved if possible.

Environment

expo-env-info 1.0.5 environment info:
    System:
      OS: Linux 6.5 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
      Shell: 5.1.16 - /bin/bash
    Binaries:
      Node: 18.16.1 - ~/.nvm/versions/node/v18.16.1/bin/node
      Yarn: 1.22.19 - ~/.yarn/bin/yarn
      npm: 9.5.1 - ~/.nvm/versions/node/v18.16.1/bin/npm
    SDKs:
      Android SDK:
        Android NDK: 26.1.10909125
    npmPackages:
      expo: 50.0.7 => 50.0.7 
      react: 18.2.0 => 18.2.0 
      react-dom: 18.2.0 => 18.2.0 
      react-native: 0.73.4 => 0.73.4 
      react-native-web: 0.19.10 => 0.19.10 
    Expo Workflow: managed

Expo Doctor Diagnostics

This issue is about expo-doctor showing an error.

brentvatne commented 7 months ago

hi there! you can ignore that peer dependency warning and take the advice from expo-doctor. the expo-modules-autolinking package is automatically installed by the expo package, but you see this warning because peer dependencies can't technically be met transitively -- even though, in this particular case, in practice, it will work.

we can likely remove the peer dependency here. perhaps it's worth us re-exporting the expo-modules-autolinking package from the expo package to clean this up, cc @tsapeta

ChromeQ commented 7 months ago

Thanks @brentvatne, yes I am aware that I can ignore it, and I will have to continue doing so in this case. I just thought I would actually read them for once and try to solve them rather than being blind to them as I was going through the effort of updating dependencies for expo 50. But it would be nice to fix warnings so that there is less noise and avoids the warning blindness many developers accrue.

github-actions[bot] commented 4 months ago

This issue is stale because it has been open for 90 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

ChromeQ commented 4 months ago

Not stale

github-actions[bot] commented 1 month ago

This issue is stale because it has been open for 90 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

ChromeQ commented 1 month ago

Not stale

expo / expo