expo / expo

An open-source framework for making universal native apps with React. Expo runs on Android, iOS, and the web.
https://docs.expo.dev
MIT License
29.64k stars 4.7k forks source link

SDK 51: Platform specific extensions not working on layout files #28690

Closed fernandasecinaro closed 1 week ago

fernandasecinaro commented 1 week ago

Minimal reproducible example

https://github.com/fernandasecinaro/expo-51-poc

Which package manager are you using? (Yarn is recommended)

yarn

If the issue is web-related, please select the bundler (web.bundler in the app.json)

None

Summary

I'm getting the following issue when trying to use a platform specific extension on layout files:

The file ./(tabs)/_layout.ios.tsx does not have a fallback sibling file without a platform extension. but I clearly have a _layout.tsx sibling file as shown in the image attached. It happens with any platform and just for layout files (route files work well).

image

Environment

System: OS: macOS 14.3.1 Shell: 5.9 - /bin/zsh Binaries: Node: 18.19.0 - ~/.nvm/versions/node/v18.19.0/bin/node Yarn: 1.22.19 - /opt/homebrew/bin/yarn npm: 10.2.3 - ~/.nvm/versions/node/v18.19.0/bin/npm Watchman: 2024.04.29.00 - /opt/homebrew/bin/watchman Managers: CocoaPods: 1.15.2 - /opt/homebrew/bin/pod SDKs: iOS SDK: Platforms: DriverKit 23.2, iOS 17.2, macOS 14.2, tvOS 17.2, visionOS 1.0, watchOS 10.2 IDEs: Android Studio: 2022.2 AI-222.4459.24.2221.10121639 Xcode: 15.2/15C500b - /usr/bin/xcodebuild npmPackages: expo: 51 => 51.0.0 expo-router: ~3.5.10 => 3.5.10 react: 18.2.0 => 18.2.0 react-dom: 18.2.0 => 18.2.0 react-native: 0.74.1 => 0.74.1 react-native-web: ~0.19.10 => 0.19.11 npmGlobalPackages: eas-cli: 9.0.0 Expo Workflow: managed

expo-bot commented 1 week ago

Thank you for filing this issue! This comment acknowledges we believe this may be a bug and there’s enough information to investigate it. However, we can’t promise any sort of timeline for resolution. We prioritize issues based on severity, breadth of impact, and alignment with our roadmap. If you’d like to help move it more quickly, you can continue to investigate it more deeply and/or you can open a pull request that fixes the cause.

marklawlor commented 1 week ago

Fixed in expo-router@3.5.11