expo / expo

An open-source framework for making universal native apps with React. Expo runs on Android, iOS, and the web.
https://docs.expo.dev
MIT License
34.19k stars 5.47k forks source link

[iOS] Facebook Ads AdTriggerView blank screen #4087

Closed Abdelrahman-Nabil closed 4 years ago

Abdelrahman-Nabil commented 5 years ago

🐛 Bug Report

Environment

Expo CLI 2.14.0 environment info: System: OS: Windows 10 Binaries: Yarn: 1.12.3 - C:\Users\Abdu\AppData\Roaming\npm\yarn.CMD npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD IDEs: Android Studio: Version 3.2.0.0 AI-181.5540.7.32.5056338

NOTE: working fine on Android, the issue is only present on iOS.

Expected Behavior

Properly navigating depending on the action (for example: install now -> navigates to App Store)

Actual Behavior

I get the following blank screen: 21e21653-9746-485f-aecf-159f15a40152

Steps to Reproduce

follow Expo's guide in documentation: https://docs.expo.io/versions/latest/sdk/facebook-ads/

Reproducible Demo

`import { FacebookAds } from 'expo'; const { AdTriggerView, AdMediaView } = FacebookAds; class AdComponent extends React.Component { render() { return (

{this.props.nativeAd.bodyText}
);

} } export default FacebookAds.withNativeAd(AdComponent);`

Notes

Unregistering components in the file: AdTriggerView.js causes the app to crash with the following error:

Got unexpected null commenting this line as a temporarily fix just to get it working, the error goes away, but the navigation issue is still not resolved: context.unregisterComponent(nullthrows(this._trigger)); line 24 in AdTriggerView.js

Ematusz commented 5 years ago

Any update on this? I'm having the same issue.

girishjjain commented 4 years ago

Are people still having the same issue with SDK v37? Looks like it is broke with SDK v37 and clicking on component in AdTriggerView tree does nothing. Does not open blank page either. Wanted to confirm before opening another issue.

cruzach commented 4 years ago

Sorry for the lack of response here, I added a comment on #8923 that will hopefully help us find out what the issue is here. Since that issue is newer and has a reproducible demo, I'm going to close this in favor of the new issue just so we can stay organized