search

expo / react-native-action-sheet

A cross-platform ActionSheet for React Native
MIT License
1.4k stars 226 forks source link

Extra black screen during sharing #203

Closed abhi0504 closed 3 years ago

abhi0504 commented 3 years ago

Hi , I am one of contributor of Zulip and we are using @expo/react-native-action-sheet in our zulip /zulip-mobile repo . One of our member reported an issue here so on working on that we had confirmed that there is a problem in @expo/react-native-action-sheet by making a tiny react app using this library . In short the problem is that when we long press on a message in our app then a messageActionList is opened and then when we click on Share option then it tooks an extra black screen to share. Detailed explaination of this issue is here Also you can reffer our chat when we try to debug this issue here

abhi0504 commented 3 years ago

I also have make tiny react native app for this issue where this issue can be elaborted easily here is the repo you can just fork this repo and then yarn and then the app is opened I am also attaching a video below you can also go through it

https://user-images.githubusercontent.com/56453541/106122275-87613380-617e-11eb-9755-34024336ee05.mp4

bradbyte commented 3 years ago

Hello @abhi0504, sorry for the delay. Were you able to determine what the issue was with the code? The Android is a custom implementation which would explain why iOS worked fine. Is it possible you could make a snack for this so it's easier to troubleshoot?

abhi0504 commented 3 years ago

Hey @bradbyte I think the issue is when we click on Share then it creates an extra screen or share the message without closing the messageActionSheet instead of this it should first close the messageActionSheet and then implement the Share . Sure I have created a snack here is the link you can have a look

kaushil111 commented 3 years ago

Facing the same issue 👍

J-Bossi commented 3 years ago

I'm facing the same issue. Seems to happen with any other modal (Share, camera, etx.), that is presented on top of this actionSheet. My hacky resolution is that a that i wrap my share action in a short timeout.

bradbyte commented 3 years ago

😢 Sorry I never followed up with this -- I am able to replicate this. I'm not sure why the setTimeout works. One possible solution is to wrap the callback internally in a setTimeout so you don't have to, or at the least update the docs so it can help guard against this. @kaushil111 @J-Bossi @abhi0504 were you ever able to figure out anything more on this?

bradbyte commented 3 years ago

@kaushil111 @J-Bossi @abhi0504 I pushed up a branch that should fix this. If you have a second, would you care to pull it in and see if it resolves your issue? Thank you!

kaushil111 commented 3 years ago

Awesome! Thanks a lot! Will take a look 👍

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 3.13.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: