expo / react-native-action-sheet

A cross-platform ActionSheet for React Native
MIT License
1.4k stars 226 forks source link

Allow multiple destructive indices #210

Closed evrimfeyyaz closed 3 years ago

evrimfeyyaz commented 3 years ago

This PR adds support for providing multiple indices to the destructiveIndex option.

This is already supported in ActionSheetIOS. Please note that React Native's type definitions are not updated and it seems that number[] is not a valid type for destructiveIndex. You can easily test it and see that it actually works though.

I have also added support for multiple destructive indices on Android.

Resolves #25.

Silvest89 commented 3 years ago

Anytime this is going to get merged? @peterpme @bradbyte

JakeSidSmith commented 3 years ago

Is there a plan for when this is going to be released?

bradbyte commented 3 years ago

@JakeSidSmith I'm sorry, I need to run the deploy script.

bradbyte commented 3 years ago

@JakeSidSmith I'm sorry for the delay 🤦🏻‍♂️ . This is now released in 3.10.0.