search

expo / react-native-action-sheet

A cross-platform ActionSheet for React Native
MIT License
1.37k stars 224 forks source link

chore: lint stack update, switch to `eslint-config-universe` #241

Closed Simek closed 3 years ago

Simek commented 3 years ago

Why

The current linting setup is a bit old and a refresh would not do any harm. 😉

How

This PR updates the whole project linting setup (ESLint & Prettier), switches to eslint-config-universe as a base for ESLint setup and simplifies the configs files as well as commands (which now include .js files in check).

I have applied the the lint changes running yarn lint with a new setup. The changes are mostly about import order/grouping and missing arrow function parentheses.

There was one warning which I had to fix manually related to usage of prevState inside of setState. Besides that the upgrade went smoothly.

Test Plan

yarn lint do not output any warnings. Example app run without an issue.

bradbyte commented 3 years ago

Thanks!

bradbyte commented 2 years ago

:tada: This PR is included in version 3.12.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: