search

expo / react-native-appearance

Access operating system appearance information (currently only light/dark mode) on iOS, Android, and web
MIT License
337 stars 40 forks source link

This library broke the entire RN gesture responder system on android #22

Closed gaodeng closed 4 years ago

gaodeng commented 4 years ago

demo video https://youtu.be/K6EdDVG05UM Please pay attention to the change of the button highlight status when scrolling.

gaodeng commented 4 years ago

here is the minimal code example that reproduces the problem

https://github.com/gaodeng/react-native-appearance-bug

brentvatne commented 4 years ago

can you show me what it is supposed to look like in a video as well?

gaodeng commented 4 years ago

@brentvatne You can reproduce the bug as follows Scroll when pressed on a button in scrollview

  1. Need to scroll longer than normal to cancel button highlighting
  2. First scroll up a distance, the button is canceled highlighting, and then scroll back down, you will find that the button is highlighted again . If you lift your finger at this time, the OnPress of the button is triggered

These behaviors will cause accidental tap issue

brentvatne commented 4 years ago

thanks, i believe i know what the issue is

brentvatne commented 4 years ago

this should be resolved in 0.2.4

gaodeng commented 4 years ago

thanks 🙏🙏🙏