search

expo / router

[ARCHIVE]: Expo Router has moved to expo/expo -- The File-based router for universal React Native apps
https://docs.expo.dev/routing/introduction/
1.36k stars 113 forks source link

fix erroneous redirect warning #873

Closed austin43 closed 1 year ago

austin43 commented 1 year ago

Motivation

Redirect warnings for should only pop up if redirect is actually passed to the component.

Execution

I fixed it because it was confusing users, and is not expected behavior.

Test Plan

Compare this to expo-router without the fix, and note that the warning does not pop up simply by importing Screen from expo-router.

marklawlor commented 1 year ago

Duplicate of https://github.com/expo/router/pull/859, https://github.com/expo/expo/pull/23932