search

expo / router

[ARCHIVE]: Expo Router has moved to expo/expo -- The File-based router for universal React Native apps
https://docs.expo.dev/routing/introduction/
1.36k stars 113 forks source link

fix: backport ENG-10211 #888

Closed marklawlor closed 11 months ago

marklawlor commented 11 months ago

Motivation

Backport https://github.com/expo/expo/pull/24598

Execution

Test Plan

linear[bot] commented 11 months ago
ENG-10211 Nested _layout.js with Slot breaking dynamic routing in expo-router 2.0.7

### This issue was automatically imported from GitHub: [https://github.com/expo/expo/issues/24576](https://github.com/expo/expo/issues/24576) #### Issue accepted by brent --- ## Summary: * The user has encountered an issue with expo-router after updating it from version 2.0.5 to 2.0.7. This was originally done to fix a navigating issue with nested slots. * Navigating to dynamic routes is broken when using nested slots. * The user's test app contains a \_layout.js file with Slot at the root and two child routes, each with its own \_layout.js file. * They have tested two ways of dynamic routing, one involving a folder name that contains the dynamic ID and one involving a filename that contains the dynamic ID. * Removing one of the child \_layout.js files fixes routing to the respective dynamic route.

pang0018 commented 11 months ago

@marklawlor now that this is merged, how soon can we expect the next release?

pang0018 commented 11 months ago

@marklawlor now that this is merged, how soon can we expect the next release?

Bump ^, or maybe @EvanBacon can share the cadence on releases?