search

expo / sentry-expo

MIT License
203 stars 83 forks source link

Can you remove the expo updates dependency? #298

Closed trajano closed 1 year ago

trajano commented 1 year ago

These lines seem to make Sentry require expo-updates but it is only meant to obtain some version which should ideally just follow the build process.

https://github.com/expo/sentry-expo/blob/b79ac904372e5593cb6976f9d7ccb313bf9b3f54/src/sentry.ts#L31-L41

For context why I am asking, there seems to be some sort of bug in expo's build system right now that causes this failure

2022-11-08T17:22:04.8738891Z [RUN_GRADLEW] e: /home/vsts/work/_temp/57864/build/node_modules/expo-updates/android/src/main/java/expo/modules/updates/errorrecovery/ErrorRecovery.kt: (7, 34): Unresolved reference: DefaultNativeModuleCallExceptionHandler
2022-11-08T17:22:04.8740539Z [RUN_GRADLEW] e: /home/vsts/work/_temp/57864/build/node_modules/expo-updates/android/src/main/java/expo/modules/updates/errorrecovery/ErrorRecovery.kt: (19, 41): Unresolved reference: DefaultNativeModuleCallExceptionHandler
2022-11-08T17:22:04.8746823Z [RUN_GRADLEW] e: /home/vsts/work/_temp/57864/build/node_modules/expo-updates/android/src/main/java/expo/modules/updates/errorrecovery/ErrorRecovery.kt: (67, 60): Unresolved reference: DefaultNativeModuleCallExceptionHandler
2022-11-08T17:22:04.8748148Z [RUN_GRADLEW] e: /home/vsts/work/_temp/57864/build/node_modules/expo-updates/android/src/main/java/expo/modules/updates/errorrecovery/ErrorRecovery.kt: (68, 7): 'handleException' overrides nothing
2022-11-08T17:22:04.8755914Z [RUN_GRADLEW] e: /home/vsts/work/_temp/57864/build/node_modules/expo-updates/android/src/main/java/expo/modules/updates/errorrecovery/ErrorRecovery.kt: (77, 35): Unresolved reference: DefaultNativeModuleCallExceptionHandler
github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 60 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem.

PhillipFraThailand commented 1 year ago

I would like to know this also. I am getting errors due to expo-updates and would like to remove it

shpetimselaci commented 1 year ago

I would like to know this also. I am getting errors due to expo-updates and would like to remove it

Same here!

ericmatte commented 1 year ago

This issue should be reopened. If we don't need expo-updates in our project, it should be an optional dependency of expo-sentry, since it causes crashes like this one on Expo 49: https://github.com/expo/expo/issues/23599.

kbrandwijk commented 1 year ago

@ericmatte The expo-updates dependency is already removed in sentry-expo@7.0.1, so let me know if this is still an issue for you