Closed kbrandwijk closed 1 year ago
π
Does https://github.com/expo/expo/blob/4fdd6db265db5fac025fffd1dbc33143d7c8a7ed/packages/expo/bundledNativeModules.json#L103 and https://github.com/expo/expo/blob/4fdd6db265db5fac025fffd1dbc33143d7c8a7ed/packages/expo/bundledNativeModules.json#L108 need to be updated?
Absolutely, which is why https://github.com/expo/expo/pull/20201 is pending merge. I always want to make sure there's no issues with the release before making it the default for everyone.
Any advice for sourcemap uploads to Sentry for EAS Updates? Will there be support for automatic upload as a post-publish hook when deploying an EAS Update? Thanks for your work on this!
You can try to adapt https://github.com/expo/expo/pull/19753#issuecomment-1350969824
There are new instructions for managing sourcemap upload when running using EAS Updates inside of the official Expo documentation: https://docs.expo.dev/guides/using-sentry/#uploading-source-maps-for-updates
Checklist
Why
This PR adds support for EAS Update.
How
This PR adds support for EAS Update through the following set of changes:
Updates.isEmbeddedLaunch
property ofexpo-updates
to determine whether a build or an update is loaded.dist
value that matches the default behavior of the embedded scripts that are used at build time to setdist
Updates.updateId
as unique identifier fordist
. Therelease
field is untouched, as the update applies to the same release (major version and build number/version code).expo-updates
required an upgrade to Expo SDK 47. This will be the minimum supported SDK release for this version.@sentry/react-native
is also bumped to the latest version@sentry/react
as a wrapper for@sentry/browser
. As this is more applicable to the web projects this libary is used for, this is now exported asSentry.React.*
. The exports also stay available throughSentry.Browser.*
for backwards compatibility purposes.Test Plan
This version of
sentry-expo
has been successfully used in manual testing in an app for both builds and updates.