expo / sentry-expo

MIT License
202 stars 83 forks source link

Add support for EAS Update #302

Closed kbrandwijk closed 1 year ago

kbrandwijk commented 1 year ago

Checklist

Why

This PR adds support for EAS Update.

How

This PR adds support for EAS Update through the following set of changes:

Test Plan

This version of sentry-expo has been successfully used in manual testing in an app for both builds and updates.

SimenB commented 1 year ago

πŸŽ‰

Does https://github.com/expo/expo/blob/4fdd6db265db5fac025fffd1dbc33143d7c8a7ed/packages/expo/bundledNativeModules.json#L103 and https://github.com/expo/expo/blob/4fdd6db265db5fac025fffd1dbc33143d7c8a7ed/packages/expo/bundledNativeModules.json#L108 need to be updated?

kbrandwijk commented 1 year ago

πŸŽ‰

Does https://github.com/expo/expo/blob/4fdd6db265db5fac025fffd1dbc33143d7c8a7ed/packages/expo/bundledNativeModules.json#L103 and https://github.com/expo/expo/blob/4fdd6db265db5fac025fffd1dbc33143d7c8a7ed/packages/expo/bundledNativeModules.json#L108 need to be updated?

Absolutely, which is why https://github.com/expo/expo/pull/20201 is pending merge. I always want to make sure there's no issues with the release before making it the default for everyone.

solarisn commented 1 year ago

Any advice for sourcemap uploads to Sentry for EAS Updates? Will there be support for automatic upload as a post-publish hook when deploying an EAS Update? Thanks for your work on this!

SimenB commented 1 year ago

You can try to adapt https://github.com/expo/expo/pull/19753#issuecomment-1350969824

solarisn commented 1 year ago

There are new instructions for managing sourcemap upload when running using EAS Updates inside of the official Expo documentation: https://docs.expo.dev/guides/using-sentry/#uploading-source-maps-for-updates