expo / sentry-expo

MIT License
202 stars 83 forks source link

Bump sentry react native version #308

Closed cheungt6 closed 1 year ago

cheungt6 commented 1 year ago

Checklist

Why

Enable the use of captureUserFeedback from the ReactNativeClient. This was introduced in a later version than currently referenced

Sentry.Native.ReactNativeClient.captureUserFeedback(userFeedback);

How

Bump the version of the library @sentry/react-native in the package.json

Test Plan

Call Sentry.Native.ReactNativeClient.captureUserFeedback(userFeedback); and view results in dashboard

cheungt6 commented 1 year ago

@kbrandwijk pls review

cheungt6 commented 1 year ago

@kbrandwijk this is done. thanks

cheungt6 commented 1 year ago

@kbrandwijk @krystofwoldrich pls merge

jbagaresgaray commented 1 year ago

@cheungt6 Please bump the version to @sentry/react-native@4.13.0 as well

@kbrandwijk @krystofwoldrich ... Kindly review and merge this as we needed the new version....

jbagaresgaray commented 1 year ago

@cheungt6 @kbrandwijk @krystofwoldrich I created a new PR with the latest @sentry/react-native

https://github.com/expo/sentry-expo/pull/314

krystofwoldrich commented 1 year ago

@cheungt6 @jbagaresgaray I can't merge in this repo. Someone from the Expo team can do it.

kbrandwijk commented 1 year ago

It seems that this bump causes ts errors.

kbrandwijk commented 1 year ago

Superseded by #314