expo / sentry-expo

MIT License
202 stars 83 forks source link

Add sdk names and versions to the client metadata #331

Closed krystofwoldrich closed 1 year ago

krystofwoldrich commented 1 year ago

Checklist

Why

The correct metadata showing sentry-expo and undelaying SDKs speedups solving issues related to the SDKs.

How

This uses the Sentry client option _metadata. https://github.com/getsentry/sentry-javascript/blob/eb898f5ba77efa0df84c8aa630113cfeb427d01e/packages/types/src/options.ts#L197

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

I've built the SDK locally and added it to my project to verify that the correct metadata is being sent. Currently in RN the SDK name and version are overwritten, but the package array holds the correct data, so it's not blocking this PR. Fix here https://github.com/getsentry/sentry-react-native/pull/3036