search

expo / sentry-expo

MIT License
202 stars 83 forks source link

fix: Dynamically resolve `collectModulesScript` script path to support monorepos #343

Closed krystofwoldrich closed 1 year ago

krystofwoldrich commented 1 year ago

Thanks to @anirudhsama and @maximgeerinck for the original workaround.

Checklist

Why

Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. closes: https://github.com/expo/sentry-expo/issues/342

How

How did you build this feature or fix this bug and why?

This is already fixed in sentry-react-native. But until released and upgraded here, this PR will work for all the versions. https://github.com/getsentry/sentry-react-native/pull/3092

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

Sample app and other users from https://github.com/expo/sentry-expo/issues/342

szt217 commented 1 year ago

Hey @krystofwoldrich , my team could use this update. Any idea when this might be merged/released? Thanks!

sergey-king commented 1 year ago

We need this too! Expo 48 + Turpoero setup - same issue. @krystofwoldrich