expo / sentry-expo

MIT License
202 stars 83 forks source link

Upgrade to sentry-react-native 5.10.0 and sentry-javascript 7.69.0 #374

Closed krystofwoldrich closed 9 months ago

krystofwoldrich commented 10 months ago

Checklist

Why

Customers having this issue have to manually upgrade the cli at the moment.

ceafive commented 9 months ago

Can we get this merged?

sergey-king commented 9 months ago

Can we get this merged?

+1

szt217 commented 9 months ago

+1. Can we get this merged, please? My team could use this update.

victoralmeidadev commented 9 months ago

Can we get this merged?

+1

raphaelm-gioa commented 9 months ago

Hi, I see this being ready and not merged, bumping 😊 thanks

sergey-king commented 9 months ago

@brentvatne anyone from the sentry team can look at this? We'd love to get this merge

rflukes commented 9 months ago

+1, would love to get this merged

brentvatne commented 9 months ago

please install sentry-expo@7.1.1 to get the version with this patch applied. once you have done so, please report back to verify that everything is working well in your app. if a few folks report back success, i'll go ahead and promote this to the default version for sdk 49

SimenB commented 9 months ago

Supersedes #358

joeporpeglia commented 9 months ago

@brentvatne after upgrading to sentry-expo@7.1.1 and @sentry/react-native@5.10.0 it looks like source maps are uploaded for both ios and android. , but stack traces aren't being mapped correctly. When I run sentry-cli sourcemaps explain it says Event exception stacktrace selected frame (0) has incorrect abs_path (valid url is required).

Both ios and android builds were done through EAS - I can provide a link to the builds if that's helpful.

Edit: Everything does seem to be working as expected! The issue I redacted was unrelated. We have a dependency that loads and runs additional JS outside the RN bundle. That JS was throwing an error and it just happened to be the first few events that came into Sentry for this release.

Arashadmin commented 7 months ago

Hi! I'm a bit confused again :/

I'm using sentry-expo@7.1.1 and @sentry/react-native@5.15.1 in order to get rid of this issue here ).

But as I can see here, sentry-expo@7.1.1 is only compatible with @sentry/react-native@5.10.0 ? I'm saying this, because my staging app is directly crashing after launching the app. Am I correct? Do you know when it'll be compatible with @sentry/react-native@5.15.1 where I can find the fix for my specific issue?

Thanks for your reply! Ari

krystofwoldrich commented 6 months ago

Hello @Arashadmin , @sentry/react-native now supports Expo out of the box!

Update to https://github.com/getsentry/sentry-react-native/releases/tag/5.16.0 or newer to get all the new features.

Migration guides available: