search

expo / sentry-expo

MIT License
202 stars 83 forks source link

PostPublish hook sometimes points to old manifest #382

Closed jparkrr closed 6 months ago

jparkrr commented 1 year ago

Summary

I'm having a problem where sentry-expo/upload-sourcemaps (link to sentry-expo), called in our postPublish hook, is publishing sourcemaps to the previously released version, not the currently releasing version.

I found in the code that it's requesting a url from the expo servers. Is it possible that this manifest isn't always updated in time when the postPublish hook runs? https://github.com/expo/expo-cli/blob/820cc0f4aa8555d8bb2aac27fc89233515236253/packages/xdl/src/project/publishAsync.ts#L146

Environment

expo-env-info 1.0.5 environment info: System: OS: macOS 13.0.1 Shell: 5.8.1 - /bin/zsh Binaries: Node: 14.20.1 - /opt/homebrew/opt/node@14/bin/node Yarn: 1.22.19 - /opt/homebrew/bin/yarn npm: 6.14.17 - /opt/homebrew/opt/node@14/bin/npm Watchman: 2022.10.24.00 - /opt/homebrew/bin/watchman Managers: CocoaPods: 1.11.2 - /Users/justin/.gem/ruby/3.0.0/bin/pod SDKs: iOS SDK: Platforms: DriverKit 22.1, iOS 16.1, macOS 13.0, tvOS 16.1, watchOS 9.1 Android SDK: API Levels: 29, 30 Build Tools: 29.0.2, 30.0.3 System Images: android-28 | Google ARM64-V8a Play ARM 64 v8a, android-32 | Google APIs ARM 64 v8a IDEs: Xcode: 14.1/14B47b - /usr/bin/xcodebuild npmPackages: @expo/webpack-config: ^0.17.0 => 0.17.2 babel-preset-expo: ~9.2.0 => 9.2.0 expo: ^46.0.16 => 46.0.16 react: 18.0.0 => 18.0.0 react-dom: 18.0.0 => 18.0.0 react-native: 0.69.5 => 0.69.6 react-native-web: ~0.18.7 => 0.18.9 npmGlobalPackages: eas-cli: 2.6.0 expo-cli: 6.0.6 Expo Workflow: managed

Please specify your device/emulator/simulator platform, model and version

n/a

Error output

No response

Reproducible demo or steps to reproduce from a blank project

PostPublish hook is configured as documented in https://docs.expo.dev/guides/using-sentry/#configure-a--postpublish--hook

It's not always reproducible. Could it be because our project is quite large?

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 60 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

github-actions[bot] commented 6 months ago

This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem.