This was surprisingly difficult to find; skaffold deploy is silently exiting with status 1 because kustomize build exits with status 1, but skaffold doesnt expose the error message which kustomize prints. Maybe newer versions of skaffold handle this better.
Test Plan
I ran kustomize build on the staging and production configuration. (CI could detect mistakes like this in future PRs by running that command).
Why
This fixes deployment.
How
This was surprisingly difficult to find;
skaffold deployis silently exiting with status 1 becausekustomize buildexits with status 1, but skaffold doesnt expose the error message which kustomize prints. Maybe newer versions of skaffold handle this better.Test Plan
I ran
kustomize buildon the staging and production configuration. (CI could detect mistakes like this in future PRs by running that command).