expo / snack

Expo Snack lets you run Expo in the browser.
https://snack.expo.dev
MIT License
372 stars 111 forks source link

[website] Mount health endpoint earlier #384

Closed nicknovitski closed 1 year ago

nicknovitski commented 1 year ago

Why

Currently rollouts are failing, because requests to /ready are being answered by a * route that is used first.

This change fixes that.

Test Plan

This can be tested by running skaffold dev --kube-context=minikube --filename website/skaffold.yaml.

nicknovitski commented 1 year ago

That's a good point, I hesitated to do that since it would technically change the behavior of the server and I thought this was less invasive, but 👍 .