search

expo / snack

Expo Snack lets you run Expo in the browser.
https://snack.expo.dev
MIT License
372 stars 111 forks source link

[snackager] Switch redis over to memorystore #386

Closed wschurman closed 1 year ago

wschurman commented 1 year ago

Why

To migrate snackager over to memorystore we need a proxy into the VPC containing the memorystore instances for local development. This is the same as the other services (www, push-hydrant).

The difference is that snackager lives in a repo outside of universe, and that repo doesn't have any of the dependencies necessary for running this proxy script or the proxy itself (gcloud). So we had a few options:

  1. Move snackager back to universe
  2. Add the dependencies to the snack repo
  3. Add a script in the universe repo that must be run in tandem with local snackager in order to develop snackager locally

I made an attempt at option 3 but the discussion on the PR settled on option 2 being the better option.

That being said, we use ./install-tools to set up gcloud in universe and we don't have an equivalent here, so I just added it to the CONTRIBUTING.md guide.

How

Copied the proxy script from universe into this repo and make it run as part of yarn start.

Test Plan

Run yarn start and ensure it works.

ide commented 1 year ago

Thank you for seeing this whole migration through!