expo / snack

Expo Snack lets you run Expo in the browser.

https://snack.expo.dev

MIT License

372 stars 111 forks source link

[snackpub] read correct remote address behind load balancer #397

Closed Kudo closed 1 year ago

Kudo commented 1 year ago

Why

follow up https://github.com/expo/snack/pull/381#discussion_r1080836193

How

read the address from the X-Forwarded-For first then the socket remote address
because cloud run doesn't log the remote address as http access log, this pr also adds remote address to log.

Test Plan

add getRemoteAddress unit test
ci passed

Kudo commented 1 year ago

Approving this PR to keep you unblocked but would appreciate it if you could address the comments by either updating the code and including test cases, or explaining why you decided not to update the code.

all comments are followed up. thanks for the neat review. i'm going to merge this pr.