search

expo / snack

Expo Snack lets you run Expo in the browser.
https://snack.expo.dev
MIT License
356 stars 104 forks source link

[website] make emotions more neutral #447

Closed kbrandwijk closed 11 months ago

kbrandwijk commented 1 year ago

Why

I noticed a few negative outliers in the range of possible emotions a Snack can have.

How

Removed a few of the ones that can invoke negative associations.

Test Plan

Didn't test. It's a list of strings...

byCedric commented 1 year ago

We do need some alternative names to avoid (accidentally) generating duplicate names (and thus overwriting older Snacks). But maybe we should add another thing instead of emotions.

kbrandwijk commented 1 year ago

87x75 (6525) down to 73x75 (5475) isn't huge, but definitely not negligible. That being said, I think the number of possibilities is still large enough though, they don't need to be globally unique, right?

byCedric commented 1 year ago

Unfortunately, they do need to be globally unique. So let's find something to bump it up to at least 6000+

We could add something boring like "weather" (sunny, rainy, windy) etc as additional set, that should boost it to the safe zone.

kbrandwijk commented 1 year ago

Or a color between the emotion and the snack? We basically only need 2 to bump it to 11,000...

byCedric commented 1 year ago

Color seems like a good option too yeah

byCedric commented 11 months ago

Merging this in, but will add color.