expo / snack

Expo Snack lets you run Expo in the browser.

https://snack.expo.dev

MIT License

366 stars 109 forks source link

fix(runtime): use `transformer.publicPath` with deploy workaround for asset paths on web #457

Closed byCedric closed 1 year ago

byCedric commented 1 year ago

Why

When importing assets from packages bundled with the Snack Runtime, the assets are expected to be hosted at the root of the domain. This adds the transformer.publicPath to tell the web export where to look up the assets.

How

Added transformer.publicPath config option based on an env flag
Updated web/deploy-script.js to enable this env flag, and move assets to the proper folders for S3 upload

Test Plan

See staging.

byCedric commented 1 year ago

Tested on staging, seems to work!