expo / snack

Expo Snack lets you run Expo in the browser.

https://snack.expo.dev

MIT License

347 stars 96 forks source link

fix: vendor `expo-modules-core` from Snack Runtime #578

Closed byCedric closed 2 months ago

byCedric commented 2 months ago

Why

Expo modules core is importing crypto in one of its files, which causes Snackager to panic. This vendors expo-modules-core and keeps it out of Snackager's list of problems.

How

Marked expo-modules-core as external in Snackager
Alias expo-modules-core in Runtime
Alias expo-modules-core in Snack Runtime (custom)

Test Plan

expo-symbols seems to be compilable by Snackager now! https://github.com/expo/snack/actions/runs/8852447955/job/24311170804