search

expo / stripe-expo

Use the Stripe HTTP API in Expo without the DOM, node, or native deps
MIT License
159 stars 23 forks source link

Current release (1.1.3) does not include important fix #22

Closed cjbutcher closed 6 years ago

cjbutcher commented 6 years ago

Pull request #20 fixes an important bug, but it is not being included when package.json reads:

"stripe-client": "^1.1.3"

Instead to get it one has to install the client using:

"stripe-client": "github:expo/stripe-expo#master"

I'm no expert in how to resolve this... perhaps tag a new release?

slorber commented 6 years ago

Hi,

I can confirm the last release published does not include this important fix.

I think latest Expo / RN release is unable to use this project, as I started getting JSON parsing errors recently, probably after upgrading to Expo 26.

Using the code of the mentionned PR does solve the problem.

Please someone of the Expo team publish a new release, there's no code change to do, just publish the existing code already on master.

cc @brentvatne @terribleben don't know who's responsible of this package as @jeff-da is not Expo anymore

jeff-da commented 6 years ago

I went ahead and updated the npm package to 1.1.5 (which includes the pull requests). Let me know if there are any other issues! :)

slorber commented 6 years ago

thanks @jeff-da nothing else to do for me

cjbutcher commented 6 years ago

thanks @jeff-da looks good to me.