expo / turtle

Standalone app builder service
MIT License
384 stars 29 forks source link

Release Channel flag does not seem to be working when building locally #290

Open dons20 opened 3 years ago

dons20 commented 3 years ago

New Issue Checklist

Issue Description

Passing the --release-channel flag into my turtle build:android command does not seem to be affecting the final apk at all. My release channels are correctly set up in the app, and I can verify that the strings do match, yet nothing seems to work, and it keeps using the default/undefined release channel.

Command executed
EXPO_ANDROID_KEYSTORE_PASSWORD="$keystore_password" \
EXPO_ANDROID_KEY_PASSWORD="$key_password" \
        turtle build:android \
        --type apk \
        --config "./$3" \
        --keystore-path $keystore_path \
        --keystore-alias $keystore_alias \
        --release-channel "$1" \
        --output "builds/$1/$2" \
        --allow-non-https-public-url \
        --public-url http://127.0.0.1:8000/android-index.json
Complete output when running turtle, including the stack trace and command used
 
The entire stack trace isn't saved, it generates lots of logs that eventually push past the maximum line history of my terminal. 
Also the turtle build process runs completely fine from what I can see, and the apk is generated.
 

Environment

 Expo CLI 4.0.17 environment info:
    System:
      OS: Linux 4.19 Ubuntu 20.04.1 LTS (Focal Fossa)
      Shell: 5.0.17 - /bin/bash
    Binaries:
      Node: 14.15.1 - ~/.nvm/versions/node/v14.15.1/bin/node
      npm: 6.14.10 - ~/.nvm/versions/node/v14.15.1/bin/npm
    npmPackages:
      expo: ^39.0.0 => 39.0.3
      react: 16.13.1 => 16.13.1
      react-dom: 16.13.1 => 16.13.1
      react-native: https://github.com/expo/react-native/archive/sdk-39.0.3.tar.gz => 0.63.2
      react-native-web: ~0.13.14 => 0.13.18
    npmGlobalPackages:
      expo-cli: 4.0.17
    Expo Workflow: managed 
dons20 commented 3 years ago

So I found one way in which I could get the release-channel to persist through my entire build process, but it is certainly anti-pattern and the bug still does exist.

Found here: https://forums.expo.io/t/expo-export-setting-release-channel/24995

I simply added "releaseChannel": "my-channel" to my app.json. It gave me a warning during the expo export process, but it didn't stop the process thankfully, and after the export was complete, the manifest contained a release-channel parameter. After the APK was generated, I was finally able to see the correct log of the release-channel I specified during the process.