expo / turtle

Standalone app builder service
MIT License
384 stars 29 forks source link

EXPO_IOS_DIST_P12_PASSWORD may not be empty #309

Open lal12 opened 3 years ago

lal12 commented 3 years ago

When calling expo build:ios with any empty EXPO_IOS_DIST_P12_PASSWORD env variable it will fail and complain that not all credentials are provided. In my case the p12 file wasn't password protected so the pw is empty.

The check for this is in src/bin/builder/ios.ts:50, there it is checked for truthyness of certPassword, however an empty string is false. So this should be adjusted to typeof provisioningProfilePath == "string"

Additionally it is checked in the joi schema in src/jobsSchemas/ios.ts:16 there .allow('') should be added.

Unfortunately this is not all and at later stages there are still complains about an invalid password.