search

expo / vector-icons

https://icons.expo.fyi
MIT License
650 stars 113 forks source link

Update to react-native-vector-icons@7.0.0 #138

Closed crux153 closed 3 years ago

crux153 commented 3 years ago

This updates react-native-vector-icons vendor files to 7.0.0, updating following icons.

react-native-vector-icons 7.0.0 removed Icon.AndroidToolbar component as it was removed from React Native core, but I don't see any reference to it in this package so I thought it is safe to bump to 7.0.0 instead of 6.7.0. (Correct me if I was wrong)

I've published the modified @ref/vector-icons package to npm to use in my project until this PR gets merged, and it seems to work just fine. Sample project under /website directory is also working and can be viewed in https://github.com/crux153/vector-icons/tree/publish branch.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/expoio/vector-icons/1iy91lm7d ✅ Preview: https://vector-icons-git-fork-crux153-react-native-vector-icons-v7.expoio.vercel.app

LRNZ09 commented 3 years ago

This would be really nice for my project too!

RealDyllon commented 3 years ago

@crux153 Nice work! How do I get @ref/vector-icons working on expo bare? I can't use the webpack alias config that you have used in the website. Is there a way to do that in babel.config.js? Couldn't getbabel-plugin-module-resolver to get it to work.

crux153 commented 3 years ago

@RealDyllon I'm just importing it directly in my app instead of modifying webpack config.

import { Ionicons } from "@ref/vector-icons";

Haven't tried using babel. What makes you unable to use webpack's alias?

brentvatne commented 3 years ago

thanks! i'll try to land the update to 7.0.0 before sdk39 is released

nandorojo commented 3 years ago

@crux153 Thank you for this!

@brentvatne Do you know roughly when this might land? Thanks!

flyingcircle commented 3 years ago

@brentvatne expo 39 has been released. Is it reasonable to expect this to be merged and released soon?

brentvatne commented 3 years ago

hi there! i'll look into it soon, sorry i have had other higher priority work

AlberErre commented 3 years ago

@brentvatne that would be great 🙌🏻, waiting for those icons!

PoulsQ commented 3 years ago

@brentvatne Having the latest one of MaterialIcon would be great too!! (like coronavirus :p) Can't wait for you to look at it! Thank. :)

pranshuchittora commented 3 years ago

Friendly ping about the status update. Any possibility of getting this merged a bit early?

brentvatne commented 3 years ago

@pranshuchittora - feel free to use the fork mentioned earlier in this thread! we plan to roll out an update to @expo/vector-icons with sdk 40 in december