expo / vector-icons

https://icons.expo.fyi
MIT License
668 stars 115 forks source link

FontAwesome5 icon set does not have any typing #161

Open soullivaneuh opened 3 years ago

soullivaneuh commented 3 years ago

Regarding the following example:

import React, { FC } from 'react';
import { View } from 'react-native';
import { FontAwesome5, MaterialIcons } from '@expo/vector-icons';

const Example: FC = () => {
  return (
    <View>
      <FontAwesome5
        name="child"
        size={40}
      />
      <MaterialIcons
        name="10k"
        size={40}
      />
    </View>
  );
};

I don't have any type checking for FontAwesome5 component but I have it for MaterialIcons (props name and glyph maps).

Currently needed for wrapper application such as https://github.com/expo/vector-icons/issues/153#issuecomment-752769305 or simply to make the code more reliable.

lucas-garrido commented 1 year ago

Could you do something about this please ? 🤔