Fix margin right

[robertonav20]

Set to 0 the margin right of the icon for to fix the position. Actually isn't possible to align the icon into the button

[vercel[bot]]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/expoio/vector-icons/9xCh3hohfTXUuPEkN2i7AxXyBNvX
✅ Preview: https://vector-icons-git-fork-robertonav20-patch-1-expoio.vercel.app

[robertonav20]

Someone can review this pr?

Maybe @brentvatne

[brentvatne]

i pulled this pr locally and ran it and i couldn't see any difference. can you post some screenshots to demonstrate the before and after?

[robertonav20]

hi @brentvatne, i just set to 0 the margin right inside this file src/vendor/react-native-vector-icons/lib/icon-button.js, because the iconButton component show the icon shifted with that margin

[robertonav20]

Here can you see the difference before and after

As you can see the difference, the icon is filled with that space

[brentvatne]

@robertonav20 - where are you seeing that? i must be missing something, i don't see an icon with a blue background anywhere on the site. please share a full page screenshot

[robertonav20]

That images are taken from my react native application. The problem is the "space" at the right of icon not the blue color

[brentvatne]

ah i see.

the intention with this library to have the exact same behavior as react-native-vector-icons but use expo-font to load the fonts. if you can convince react-native-vector-icons to land this change, then we will pull it in here too. https://github.com/oblador/react-native-vector-icons/blob/b9f24f9b3a16fa5df8c2a7a6cb1f01b90d49b80d/lib/icon-button.js#L16-L18

thanks for following up on this!