expo / vector-icons

https://icons.expo.fyi
MIT License
647 stars 114 forks source link

Feather shopping-icon is unexpected #213

Closed terrierscript closed 6 months ago

terrierscript commented 2 years ago

Feather icon is all outline style. But current feather shopping-cart icon is solid style. In react-native-vector-icons has outline shopping-cart but expo/vector-icons got solid

gclark-eightfold commented 2 years ago

I was noticing the same thing with missing MaterialCommunityIcons like office-building-outline, database-outline, database-arrow-down, and many more. Looks like the last time the vendor was updated was on Dec 1, 2020, which would likely be v7.1.0 of react-native-vector-icons and the fixes for both our icon libraries is included in v9.1.0

I'm sure there's a good reason for this package to clone the vendor rather than making it a dependency, but if it's for Expo Go compatibility, it might be worth trying to simply import react-native-vector-icons directly if you're using a bare or EAS workflow.

Trying to see if it's possible to use react-native-vector-icons directly, but not having much luck so far. Seems like @expo/vector-icons is still being cached for some reason.

gclark-eightfold commented 2 years ago

Update: Turns out the issue I was having with using react-native-vector-icons directly was b/c babel-preset-expo creates an alias to override the package to use @expo/vector-icons.

Instead of falling down that rabbit hole though, I was able to update the @expo/vector-icons package to use v9.1.0 in #214 , so hopefully if there's any maintainers that can verify the changes this will be fixed. 😄

gclark-eightfold commented 2 years ago

Update: While the PR is being reviewed, I created a gist that might help out patch the package before it's fully updated that works well when I've tested: https://gist.github.com/gclark-eightfold/36dc1e2f560fa6775049d94ae263ad7f Hope that helps 😄