expo / vector-icons

https://icons.expo.fyi
MIT License
647 stars 114 forks source link

Able to gets icons as file or base64 string #221

Open AlenToma opened 2 years ago

AlenToma commented 2 years ago

This issue is related to https://github.com/expo/expo/issues/17602

I figure that since the app cant display icons without internet so I wanted to download the icons the first time the app run and has internet and then cache those icon as a file or a base64string so it could be loaded when there is no internet.

The problem is that expo dose not provide access to Icon.getImageSource() for some reason, even if I am using this library in bare project.

Then I figure using @oblador/react-native-vector-icons instead but still somehow expo override those settings, this is really bad as it should be optional and we should choose either we would want to use it or not.

Could you please provide Icon.getImageSource() or something similar.

You could simple say cache those images on a bundle, this I cannot do because there is simple to many icons for different themes and mobiles, so adding those images in apk is simple not something I would like to do.

DianaLaa commented 1 year ago

Where did you read that "the app cant display icons without internet"? Can you provide a source for this? I thought the icons were just bundled in the app?

AlenToma commented 1 year ago

I found that I get the issue after i publish a new update to expo and my app get the update. expo publish do not boundle the icons it seems