expo / vector-icons

https://icons.expo.fyi
MIT License
647 stars 114 forks source link

Upgrade react-native-vector-icons to 10.0.0 #266

Closed cabarbato closed 5 months ago

cabarbato commented 11 months ago

Includes changes to MaterialIcons and IonIcons, addition of FA6.

Notes:

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vector-icons ❌ Failed (Inspect) Jul 27, 2023 5:22pm
Simek commented 5 months ago

Thanks for working on this upgrade @cabarbato. 👍 We have updated the the vendored package in a separate PR, and new 14.0.0 releases is based on vector-icons 10.0.3 release.

For the older aliases in FA6 it would be nice to make them work, I have made small tweaks towards that, but stil some od the aliases are the problem. In general we should not modify any vendored code, but maybe we can handle this situation better in create set method, as you mentioned. I will be looking at possible solutions for this problem soon.

So, closing this PR, as the bump has happen separately, but feel free to open a new PR if I have missed or messed up anything. 😉