search

expo / videoplayer

Customizable controls for Expo video
83 stars 83 forks source link

Add playThroughEarpieceAndroid default #38

Open ghost opened 5 years ago

ghost commented 5 years ago

With

"dependencies": {
    "@expo/videoplayer": "0.4.0",
    "expo": "30.0.1",
    "react": "16.3.1",
    "react-native": "https://github.com/expo/react-native/archive/sdk-30.0.0.tar.gz"
}

resolving:

[Unhandled promise rejection: Error: Audio mode attempted to be set without the required keys: ["playThroughEarpieceAndroid"]]
- node_modules/expo/src/av/Audio.js:66:10 in setAudioModeAsync$
...
chris35469 commented 5 years ago

Please accept this.

staticdreams commented 5 years ago

This is still not merged. Please accept

sheyooo commented 5 years ago

Why hasn't this been merged yet?

ManuelKu1223 commented 5 years ago

I have similar issue on my react native project. This issue is: [Unhandled promise rejection: Error: Audio mode attempted to be set without the required keys: ["playThroughEarpieceAndroid"]]

Please help me, How can I fix this issue? Thanks

jcohoon commented 5 years ago

@kolawoletech did you look at the code in this commit?

https://github.com/expo/videoplayer/commit/ce44a1abc7addf350f8a4fab7672f52bb3d4e1f8

mtaylor769 commented 5 years ago

Can someone merge this?

cloudSchulze commented 5 years ago

Please, can someone merge this? We need this fix :(

fweffort commented 5 years ago

will this be merged soon?

cruzach commented 5 years ago

Hey everyone, sorry for the long silence here. This repo isn't maintained anymore, so we suggest using https://github.com/ihmpavel/expo-video-player instead (we actually point to this repo anyways in the Expo Video docs)

Again, sorry this repo went silent for so long!