search

expo / vscode-expo

Expo Tools keep you productive with debugging, IntelliSense, and prebuild previews
https://marketplace.visualstudio.com/items?itemName=expo.vscode-expo-tools
MIT License
433 stars 11 forks source link

fix: preview modifiers for dynamic config apps #121

Closed byCedric closed 2 years ago

byCedric commented 2 years ago

Linked issue

Fixes #62

This fixes the preview modifiers for dynamic configs, like app.config.js and app.config.ts.

Additional context

The workaround is kinda hacky, but it does work. The issue with "normally" bundling sucrase is that the esm exports aren't playing nice within sucrase. NameManager.mjs is imported with { esm: true, default: ... } while it doesn't expect that in the index.mjs, resulting in s cannot be instantiated errors.

It's probably our settings, since typescript doesn't complain about import vscode from 'vscode'; while I think only import * as vscode from 'vscode'; works. We probably need to dig into that later, and we could revert the workaround.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 0.8.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: