App json set to "JSON" language, and not "JSON5"

expo / vscode-expo

Expo Tools keep you productive with debugging, IntelliSense, and prebuild previews

https://marketplace.visualstudio.com/items?itemName=expo.vscode-expo-tools

MIT License

433 stars 11 forks source link

App json set to "JSON" language, and not "JSON5" #66

Closed byCedric closed 2 years ago

byCedric commented 3 years ago

Description of the bug

The app.json is set to default JSON, while the app manifest is parsed as JSON5.

To Reproduce

Open app.json, add a comment (JSON5 feature)

Expected behavior

The plugin would set JSON5 instead of requiring it to do that manually.

Actual behavior

Errors on the JSON comment

byCedric commented 2 years ago

closing, this would probably confuse users

byCedric commented 2 years ago

Now that EAS supports json5, I'm reopening this to enable this from the extension. Luckily, we use jsonc-parser which supports comments as well, so no changes required from within the extension.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 0.9.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: