search

exponea / bloomreach-magento2-integration

MIT License
1 stars 5 forks source link

Added order_id to collection query #30

Closed julian-van-drielen closed 1 year ago

julian-van-drielen commented 1 year ago

By querying directly on parent_item_id results in a full table scan every time. This causes a severe performance issue when the sales_order_item contains millions of records.

By also querying on order_id, results in just scanning all items in a single order, as this field is indexed.

julian-van-drielen commented 1 year ago

Updated pull request, as I've found another severe performance issue where a full table scan is executed on sales_order_item

eduard13 commented 1 year ago

Hi @julian-van-drielen, thank you for your suggestions, we will definitely include them into our next release.

May I ask you to merge the latest main changes into your working branch in order to fix the failed builds?

Thank you.

julian-van-drielen commented 1 year ago

Hi @eduard13,

I've done this now, however, build is still failing.

eduard13 commented 1 year ago

Hi @julian-van-drielen, we'll process and deliver your PR internally and release within the next upcoming release. In the meantime, feel free to apply these changes as a patch.

Thank you for your great contribution.

eduard13 commented 1 year ago

Hi @julian-van-drielen, these changes were successfully added into 1.0.0 release.

Thank you for your contribution

Resolving this PR.