search

exponea / exponea-ios-sdk

MIT License
19 stars 27 forks source link

call UIAppliaction method on main thread #18

Closed anonymcek closed 3 years ago

anonymcek commented 3 years ago

from UNUserNotificationCenter.requestAuthorization(options:, completionHandler:) docs:

completionHandler
The block to execute asynchronously with the results. This block may be executed on a background thread.

UIApplication.shared methods should be called on main thread.

wassil commented 3 years ago

The main thread issue was already reported in https://github.com/exponea/exponea-ios-sdk/issues/16 We have fixed this issue on the internal clone of this repo and it will be part of the next release.

I like the change to support both Swift 4.2 and 5.0, docs say they're interchangable.

If you don't mind I'll close this and do the swift support change on our internal repo, I think it's the easiest in this case

anonymcek commented 3 years ago

I forgot to browse issues, but thanks for the fix. Do you have any ETA for next release?

wassil commented 3 years ago

We're targeting August 10th, there are a few more fixes that have to go through review

wassil commented 3 years ago

Hey, version 2.8.0 has just been released, contains the changes you did here.