search

exponea / exponea-ios-sdk

MIT License
19 stars 27 forks source link

AppStore upload failed #33

Closed milanhorvatovic closed 2 years ago

milanhorvatovic commented 2 years ago

Hi, we faced a problem with uploading a new version of our application to the App Store with received errors:

After a short investigation in your latest release, I found the settings for ExponeaSDK target has 2 dependencies:

Both of those dependencies have an embed style as Embed & Sign that is the problem cause frameworks don't have allowed containing any nested bundles, which in that case are real frameworks.

Other than that, you should consider enabling the flag BUILD_LIBRARY_FOR_DISTRIBUTION to enable library evolution support for built frameworks.

michaela-dev commented 2 years ago

Hi, can you share (maybe screenshot) your targets and build settings? Mainly in part "Embedded code contains swift code" + and "Framework search paths". It would be a big help. Thanks!

milanhorvatovic commented 2 years ago

Build settings for our project are:

To be honest, I don't think that the problem is in our project settings. We haven't had the problem with uploading binary to AppStore with embedded ExponeaSDK in our project until we updated to the latest v2.11.1 version. I checked your source code again and the problem is that commit d3c9413. The commit that you made define ExponeaSDKObjC and ExponeaSDKShared frameworks as not only dependencies, but also embed them directly in ExponeaSDK archived binary (Embed & Sign).

We fixed our current situation by manual change in your project settings with simple change to Embed strategy from Embed & Sign to Do Not Embed.

michaela-dev commented 2 years ago

Great, thanks for the feedback! We will fix this in the next release.

milanhorvatovic commented 2 years ago

I think the whole commit d3c9413 fix/Include frameworks in SDK as required could be removed, because it does nothing after all. Embed strategy Do Not Embed doesn't affect anything. Am I wrong, or do I miss something?

michaela-dev commented 2 years ago

Thanks again for noticing this, ExponeaSDKObjC and ExponeaSDKShared are not embedded anymore on version 2.11.2