search

exponea / exponea-ios-sdk

MIT License
19 stars 27 forks source link

Exponea SDK is broken since 2.12.0 #36

Closed username0x0a closed 1 year ago

username0x0a commented 1 year ago

Getting an error during configuration – complaining about database initialisation. Referenced in our project as a source Swift package.

My guess would be this change made in that release:

//        #if SWIFT_PACKAGE
//        let bundle = Bundle.module
//        #else
//
//        #endif

so that the proper Bundle, thus the database model file as well, can't be resolved properly.

That release seems to be pretty wild on its own, with +14000 line diff, not really reviewed or tested properly, seems like.

adam1929 commented 1 year ago

Thank you for detailed reporting. We were adding a new feature that required lot of changes to support Carthage, SPM and Cocoapods managers. This database handling has been changed due to 'obsolete' usage reported by XCode 13, but we will look at it again.

adam1929 commented 1 year ago

@username0x0a May I ask for some error message or anything? This problem seems to be related with SPM. Which version XCode you have? It (probably) is runtime issue, which iOS version is affected? etc... Thank you

username0x0a commented 1 year ago

The thrown error is .unableToCreatePersistentContainer, originating here.

As mentioned, very probably caused by invalid Bundle resolution causing the database model file not to be found.

Xcode 13.4.1, iOS 14+, integrated & built via SPM

adam1929 commented 1 year ago

@username0x0a Thank you, we found a problem in SDK. Yes indeed, we comment out that part of code for invalid reason, this version of SDK is incopatible with SPM usage. We'll revert this change asap, in next iOS SDK release

adam1929 commented 1 year ago

@username0x0a our next iOS release (very soon) will contain fix for that issue. Thank you for reporting it