search

exponea / exponea-ios-sdk

MIT License
19 stars 27 forks source link

Fix Carthage integration #43

Closed olejnjak closed 1 year ago

olejnjak commented 1 year ago

As Carthage uses xcodeproj file, that is committed in repository, it needs to be set up correctly.

Current project file caused bunch of warnings in console to appear - reason is that in project file there is SwiftSoup as SPM dependency, which is static. That means that once ExponeaSDK is linked to app, SwiftSoup is present twice, once in the app and once in ExponeaSDK. This could even lead to issues in case that SPM dependency is different version from binary built by Carthage.

This PR fixes this integration by linking SwiftSoup through Carthage without embedding it to ExponeaSDK target as embedding it is app's responsibility.

I also deleted committed SwiftSoup binary as I think that there is no reason to have it there.

olejnjak commented 1 year ago

Hello? 👋

adam1929 commented 1 year ago

Thank you for your PR. We are currently working on carthage/spm/cocoapods integration fix.

olejnjak commented 1 year ago

Okay and is there any estimate?

xcibik00 commented 1 year ago

Hi @olejnjak, it will be a part of next iOS release