search

exponea / exponea-ios-sdk

MIT License
19 stars 27 forks source link

Reachability as internal class #7

Closed anonymcek closed 4 years ago

anonymcek commented 4 years ago

This definition could interfere with Reachability framework, therefore it should be defined as internal, or be removed altogether from project in future. Probably the best way to fix this would be to remove Reachability from this project and define it as a dependency. (This would make standalone installation less straightforward)

wassil commented 4 years ago

Hi, we have renamed the Reachability class to ExponeaReachability and made it internal. Will be included in next release of the SDK, which should be out soon. I agree with you that ideally we would like to have Reachability as a dependency, but it gets pretty complicated since our library supports pods, carthage and will (most likely) support swift package manager in the future.

Sorry that this took so long, we missed this and your update notified us.

I'll update this once new SDK version is out

wassil commented 4 years ago

This has been fixed in 2.6.0 Reachability was renamed to ExponeaReachability