search

exponea / exponea-react-native-sdk

MIT License
8 stars 13 forks source link

Android react native version dependency is hardcoded with version 1.5.0 #87

Closed gdhillon-pbl closed 1 year ago

gdhillon-pbl commented 1 year ago

Android react native version dependency is hardcoded with version 1.5.0 and it will not work with lower versions of react native.

implementation "com.facebook.react:react-android:0.71.8"

File: https://github.com/exponea/exponea-react-native-sdk/blob/1.5.0/android/build.gradle

adam1929 commented 1 year ago

Hi @gdhillon-pbl thank you. Which RN are you using? From RN 0.71.0, architecture has changed and Android RN is not within RN library :-/ only this dependency notation works. Thank you

gdhillon-pbl commented 1 year ago

@adam1929 to support that it will be good to do like this, otherwise it will fail anything not 0.71.8

  if (REACT_NATIVE_VERSION >= 71) {
      implementation "com.facebook.react:react-android:"
  } else {
      // noinspection GradleDynamicVersion
      implementation 'com.facebook.react:react-native:+'
  }

Thanks!!

Vinanti-Pansari commented 1 year ago

@gdhillon-pbl , is this working for you? I have tried both versions but it is not working for me. I raised bug, please have a look https://github.com/exponea/exponea-react-native-sdk/issues/88

adam1929 commented 1 year ago

Hi guys. Thank you @gdhillon-pbl for your idea. We applied it into current release 1.5.1. It was needed on multiple places (due to gradle plugin, dependencies, etc.) but core is your idea. Thank you