exponea / exponea-react-native-sdk

MIT License
8 stars 13 forks source link

Not able to build Android app with react-native-exponea-sdk veriosn 15 #88

Closed Vinanti-Pansari closed 1 year ago

Vinanti-Pansari commented 1 year ago

here is the error, that I am getting after upgrading Exponea SDK version ( this issue is related to Android only)

I have tried with react native version 0.70.6 and 0.71.8, but the same issue I am facing. (node verion: 18.7.0)

This issue is on priority, waiting for the quick reply to fix this issue

error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup. Error: Command failed: ./gradlew app:installDevelopmentDebug -PreactNativeDevServerPort=8081 node:internal/fs/utils:348 throw err; ^

Error: ENOENT: no such file or directory, lstat '/appPath/node_modules/react-native-exponea-sdk/src' at Object.lstatSync (node:fs:1574:3) at /appPath/node_modules/react-native-codegen/lib/cli/combine/combine-js-to-schema-cli.js:75:10 at Array.forEach () at Object. (/appPath/node_modules/react-native-codegen/lib/cli/combine/combine-js-to-schema-cli.js:74:10) at Module._compile (node:internal/modules/cjs/loader:1120:14) at Module._extensions..js (node:internal/modules/cjs/loader:1174:10) at Module.load (node:internal/modules/cjs/loader:998:32) at Module._load (node:internal/modules/cjs/loader:839:12) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) at node:internal/main/run_main_module:17:47 { errno: -2, syscall: 'lstat', code: 'ENOENT', path: '/appPath/node_modules/react-native-exponea-sdk/src' }

frenic commented 1 year ago

Same here. Trying to upgrade react-native@0.71.8 and react-native-exponea-sdk@1.5.0.


> Task :react-native-exponea-sdk:generateCodegenSchemaFromJavaScript FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.5.1/userguide/command_line_interface.html#sec:command_line_warnings
8 actionable tasks: 3 executed, 5 up-to-date
/home/frenic/dev/lykoapp/node_modules/flow-parser/flow_parser.js:807
throw a}function
^

Error: ENOENT: no such file or directory, lstat '/home/frenic/dev/lykoapp/node_modules/react-native-exponea-sdk/src'
    at Object.lstatSync (node:fs:1574:3)
    at /home/frenic/dev/lykoapp/node_modules/react-native-codegen/lib/cli/combine/combine-js-to-schema-cli.js:30:10
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (/home/frenic/dev/lykoapp/node_modules/react-native-codegen/lib/cli/combine/combine-js-to-schema-cli.js:29:10)
    at Module._compile (node:internal/modules/cjs/loader:1218:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1272:10)
    at Module.load (node:internal/modules/cjs/loader:1081:32)
    at Module._load (node:internal/modules/cjs/loader:922:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47 {
  errno: -2,
  syscall: 'lstat',
  code: 'ENOENT',
  path: '/home/frenic/dev/lykoapp/node_modules/react-native-exponea-sdk/src'
}

Node.js v18.13.0
frenic commented 1 year ago

This react-native-exponea-sdk+1.5.0.patch seems to solve it:


diff --git a/node_modules/react-native-exponea-sdk/package.json b/node_modules/react-native-exponea-sdk/package.json
index bb05dd6..81dece0 100644
--- a/node_modules/react-native-exponea-sdk/package.json
+++ b/node_modules/react-native-exponea-sdk/package.json
@@ -76,13 +76,5 @@
         "react"
       ]
     }
-  },
-  "codegenConfig": {
-    "name": "example",
-    "type": "all",
-    "jsSrcsDir": "src",
-    "android": {
-      "javaPackageName": "com.exponea"
-    }
   }
 }
Vinanti-Pansari commented 1 year ago

@frenic, is this worked for you?

frenic commented 1 year ago

Yes, it works for me

Vinanti-Pansari commented 1 year ago

Thanks @frenic :) I am on RN version 0.70.6 and for this version this patch file works for me

Screenshot 2023-06-07 at 11 38 14 PM

for creating this patch I excluded all things apart from the required one yarn patch-package --exclude 'android/build/' react-native-exponea-sdk

frenic commented 1 year ago

Well, it should be permanently fixed as well @adam1929 @Vinanti-Pansari so perhaps this should be opened again?

adam1929 commented 1 year ago

Thanks @frenic for patch, we removed this part, is in 1.5.1. This codegenConfig has been added by RN migration tool for 0.70.6. I removed it, it has no (negative) impact on build process. We are using YARN do build app, maybe it handle it correctly.