exponentcms / exponent-cms

Content Management, Simple.
exponentcms.org
GNU General Public License v2.0
60 stars 24 forks source link

Feature request - Update to Bootstrap 3/FontAwesome 4 #1131

Closed exponentcms closed 4 years ago

exponentcms commented 4 years ago

Twitter Bootstrap is now officially at v3.0.0, and our lessphp integrated compiler should compile it, HOWEVER, Font Awesome is NOT yet integrated and our icons come from Font Awesome

exponentcms commented 4 years ago

Font Awesome 4.0.1 has been released, but the usage has changed somewhat

exponentcms commented 4 years ago

Here's a list of changes moving from bootstrap 2 to 3 http://getbootstrap.com/getting-started/#migration

Here's a list of (bigger) changes moving from font-awesome 3 to 4 https://github.com/FortAwesome/Font-Awesome/wiki/Upgrading-from-3.2.1-to-4

exponentcms commented 4 years ago

Due to the drastic changes between versions, we will likely BREAK any existing bootstrap themes. We MAY have to move to a 3rd framework type of 'bootstrap3' to alleviate this meaning subfolders of bootstrap3, etc... though it looks like we really don't need the 'jquery' framework.

FWIW, I have a preliminary code working...bootstrap v3.0.1 will NOT compile with out less compiler, and we'll likely have to create a bootstrap version of all our controls since all form controls now must pick up a 'form-control' class to display properly.

Otherwise, the MANY changes to class names (icons & styles, etc...) are not that difficult, but are quite numerous.

exponentcms commented 4 years ago

(from [78ca846e0163e54e78f96fe6b2f30a2797727813]) Adds/Updates to Bootstrap 3 FontAwesome 4 [#1087] https://github.com/exponentcms/exponent-cms/commit/78ca846e0163e54e78f96fe6b2f30a2797727813

exponentcms commented 4 years ago

(from [d6a24a6de1223240151b442de9ed6123a3532279]) Missing Bootstrap 3 FontAwesome 4 files [#1087] https://github.com/exponentcms/exponent-cms/commit/d6a24a6de1223240151b442de9ed6123a3532279

exponentcms commented 4 years ago

(from [a4ffc091172e3d83c7fbaf051925bf8828fe0caa]) Reverts Bootstrap3 to v3.0.0 since later version don't compile with lessphp [#1087] https://github.com/exponentcms/exponent-cms/commit/a4ffc091172e3d83c7fbaf051925bf8828fe0caa

exponentcms commented 4 years ago

FWIW, this is implemented in the bootstrap3dave branch on github...we add a 3rd framework type of 'bootstrap3'

exponentcms commented 4 years ago

(from [04e1bf52722a27971d358f16715956e68f0e6891]) Adds BootSwatch 3.02+2 to Bootstrap v3 implementation [#1087] https://github.com/exponentcms/exponent-cms/commit/04e1bf52722a27971d358f16715956e68f0e6891

exponentcms commented 4 years ago

This work is being done on the bootstrap3dave github branch

exponentcms commented 4 years ago

Though we have a working implementation of Bootstrap v3.0.0, the current version is v3.0.3 which will NOT compile using lessphp. We may have to move to use less.php which is a more current less compiler and will compile bootstrap v3.0.3. The caching and variable injection approach are much different, but we do all the compilation within the expCSS subsystem anyway.

exponentcms commented 4 years ago

Initial test of less.php shows that less compilation takes some time and the caching feature is mostly undocumented for what we need (only compile if needed, etc...). Also having difficulty getting bootstrap to compile to anything but an empty css file with only the header.

exponentcms commented 4 years ago

(from [0021592fabc07b9871ce1dcfc6d7f4e5eb4bd8ef]) Updates Bootstrap v3 to v3.0.3 (with some edits to compile under lessphp) and prevents loading of normalize.css in boostrap3 since it's already a part of bootstrap v3 [#1087] https://github.com/exponentcms/exponent-cms/commit/0021592fabc07b9871ce1dcfc6d7f4e5eb4bd8ef

exponentcms commented 4 years ago

As a note, it appears development of lessphp has stagnated by the original developer, so we switched to using an edited version of the bootstrap less file to get it to compile since the php.less doesn't seem to work for us yet.

exponentcms commented 4 years ago

(from [93ff97b494c225751c3f6eb04fe3141074693f9c]) Lots of code tweaks to apply more recent updates to the bootstrap3 stuff [#1087] https://github.com/exponentcms/exponent-cms/commit/93ff97b494c225751c3f6eb04fe3141074693f9c

exponentcms commented 4 years ago

(from [b0f9154cee26ee32fd502e1f08119b3ecaaec83f]) Missing file from - Lots of code tweaks to apply more recent updates to the bootstrap3 stuff [#1087] https://github.com/exponentcms/exponent-cms/commit/b0f9154cee26ee32fd502e1f08119b3ecaaec83f

exponentcms commented 4 years ago

We have bootstrap 3.1.1 and font-awesome v4.0.3 working in the bootstrap3dave branch using the newer less.php less compiler which easily compiles bootstrap v3 as is

exponentcms commented 4 years ago

At this point the bootstrap3dave branch has been kept up to date with the develop branch and should be suitable for reintegration back into develop...HOWEVER it would likely interfere with the NEWUI development, so we'll postpone reintegration.

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

Lighthouse URL: https://exponentcms.lighthouseapp.com/projects/61783/tickets/1087