search

exponentcms / exponent-cms

Content Management, Simple.
exponentcms.org
GNU General Public License v2.0
60 stars 24 forks source link

Upgrade: scssphp v1.0.9+ to compile newui.scss #1376

Closed exponentcms closed 4 years ago

exponentcms commented 4 years ago

Due to an inability to compile nested .scss files, we are unable to update the scssphp compiler (0.3.1 was hacked to allow it to compile). There is a ticket open https://github.com/leafo/scssphp/issues/380

exponentcms commented 4 years ago

scssphp now at v0.6.3

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

It appears this is not isolated to file import nesting, but to encapsulating or sub-classing which is how we do the newui toolbar.

exponentcms commented 4 years ago

Note: the version we ship will compile Bootstrap 4 up through the alpha releases, but doesn't provide the scss features needed to compile the beta release. The most recent scssphp version WILL compile the Bootstrap 4 beta release, but will NOT compile the expskin/newui stylesheet since it is encapsulated.

exponentcms commented 4 years ago

Scssphp v0.7.1 is out, but still has a bug when it comes to compiling our nested variation of bootstrap for the newui skin. HOWEVER, I've hacked it to compile correctly (this is not a universal scssphp fix since it likely increases compilation time and also makes assumptions on the number of variables)

exponentcms commented 4 years ago

(from [cee2b1c9350e00ed04716911b11e2b9f1c57257e]) update scssphp to v0.7.1 with newui/bootstrap hacks [#1332] [#1313] https://github.com/exponentcms/exponent-cms/commit/cee2b1c9350e00ed04716911b11e2b9f1c57257e

exponentcms commented 4 years ago

We are currently at scssphp v0.7.4 which includes source mapping and an exponent hack to compile the newui wrapper on bootstrap.

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

As a note, we are using the most recent version which hasn't been updated in a while, however it requires a hack to get it to complile some scripts.

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

We have implemented a 'hack' to compile newui.scss correctly which allows maintaining the current version of scssphp, but it would be nice to have the main library work correctly when encapsulating the newui styles.

exponentcms commented 4 years ago

scssphp v1.1.0 appears to have finally fixed this issue where we can now compile newui out of the box.

exponentcms commented 4 years ago

Lighthouse URL: https://exponentcms.lighthouseapp.com/projects/61783/tickets/1332