exponentcms / exponent-cms

Content Management, Simple.
exponentcms.org
GNU General Public License v2.0
60 stars 24 forks source link

IE10+ Compatibility #1455

Closed exponentcms closed 4 years ago

exponentcms commented 4 years ago

Whilst fixing a css formatting bug in IE11, I notice that you have in the loaded page source code a couple of workaround statements that do not work in IE10+:

As I understand it, the 'if' statements are no longer supported and so these lines do not load. I have used @media in my CSS for my workaround. It may be you have the workaround elsewhere, but I thought I'd better mention it. Peter.
exponentcms commented 4 years ago

They should NOT be loading, as those fixes aren't needed in newer versions of IE. The only apply to IE 10 under Windows 8? http://getbootstrap.com/getting-started/#support-ie10-width

exponentcms commented 4 years ago

Hi Dave. Yes, but my understanding was that <!--[if IE 10]> is ignored by IE10+ so the statement doesn't do anything.

The specific problem that I have is the positioning of "leftcol" (which is in fact the right column on the web site). On all non-ie browsers the positioning is controlled by:

leftcol{ margin-left: 745px; }

In IE11 there was no sign of the left column. To fix this I needed:

@media screen and (-ms-high-contrast: active), screen and (-ms-high-contrast: none) {
/ IE10+ specific styles go here /

leftcol {

margin-left: 7px;

} }

Also Edge did the disappearing act too, but had to be fixed with:

@supports (-ms-ime-align:auto) { .selector { property:value; } }

exponentcms commented 4 years ago

You are probably correct...for the next patch/release, we'll remove the 'if' statements...I've also updated the .css and .js code to more recent flavors.

It's unlikely we'd imcorporate the IE11/Edge fixes since they seem like more of a custom approach and may interfere with some theme style approaches?

exponentcms commented 4 years ago

I just wish the browser developers would stop delivering big bags of worms... The ultimate challenge became Chrome vs. Safari. Both use the same engine so a fix for one fixes the other. Except one needed the big margin and one the small margin. In the end I gave up on fixing the leftcol and floated it instead, thus negating the need for the other fixes.

I suppose you could consider putting the IE10+ statement at the end of 0-basestyles without any actual modified tags, suitably commented that the developer can add custom tags here if needed. The Edge fix just seemed to work. You could also add it but commented out, so at least saving people time looking for how to fix a problem.

Thanks again for your help with my problems.

Peter.

exponentcms commented 4 years ago

Fix included in next patch

exponentcms commented 4 years ago

Lighthouse URL: https://exponentcms.lighthouseapp.com/projects/61783/tickets/1412