search

exponentcms / exponent-cms

Content Management, Simple.
exponentcms.org
GNU General Public License v2.0
59 stars 24 forks source link

Empty Email Form Submissions #1492

Closed exponentcms closed 4 years ago

exponentcms commented 4 years ago

In 2.5.1 p1, new forms send empty form submissions. Existing forms work well, but copied old, working forms also send empty mails.

exponentcms commented 4 years ago

Just to confirm, you receive the email, but it's empty? Is there any custom 'Report'?

exponentcms commented 4 years ago

I've found the issue which is a result of the fix for MySQL 'strict' mode. Since boolean fields as of v2.5.1p1 now allow null values, a boolean field could contain NULL as a default entry instead of 0 or 1, AND we were testing for 0 not NULL.

exponentcms commented 4 years ago

The fix will be pushed shortly and will be distributed as v2.5.1patch2 in a few days. There are likely several other scenarios which also fail if the MySQL server is running in strict mode.

Note: this only occurs when in 'strict' mode and doesn't appear in other MySQL modes.

exponentcms commented 4 years ago

Still finding additional 'strict' mode anomalies preventing release of next patch.

exponentcms commented 4 years ago

Ok, for the time being I've put an 'old' form in place (didn't test for this before upgrading..), but am really looking forward to the patch. Haven't found anything elkse (luckily). Unfortunately I have no control over the database settings...

exponentcms commented 4 years ago

Lighthouse URL: https://exponentcms.lighthouseapp.com/projects/61783/tickets/1451

dleffler commented 4 years ago

This should be fixed within v2.5.1patch2