search

exponentcms / exponent-cms

Content Management, Simple.
exponentcms.org
GNU General Public License v2.0
59 stars 24 forks source link

Bug: javascript actions inside tabbed containers do NOT fire #1500

Closed exponentcms closed 4 years ago

exponentcms commented 4 years ago

When you load an events module inside a nested container with the tabbed view, the ajax doesn't fire, so you end up on a new page (which is acceptable)

This likely applies to other ajax actions such as blog/news pagining, etc...

exponentcms commented 4 years ago

This applies to all javascript inside the tab. Likely the resolution will involve a variation of the ckelazy fix.

exponentcms commented 4 years ago

I appears that tabs will build inside of tabs, but if the initially displayed tab contains some yui jscript, it may break and the container/page won't build.

exponentcms commented 4 years ago

(from [0d9463b59f67f80629c7d05e5706dab248344904]) Resolves bug with javascript actions not 'firing' inside tabbed containers by replacing non-admin tabs w/ jquery ones, also adds a new jqueryui 'exponent' theme to somewhat mimic exponent tab colors [#816 state:resolved] https://github.com/exponentcms/exponent-cms/commit/0d9463b59f67f80629c7d05e5706dab248344904

exponentcms commented 4 years ago

Should note that we LOSE tab history (at least for now, maybe forever?)

exponentcms commented 4 years ago

(from [861fc5cc0b9b266b439836763ecee3fa9ae4506f]) The files for the new jqueryui 'exponent' theme to somewhat mimic exponent tab colors [#816 state:resolved] https://github.com/exponentcms/exponent-cms/commit/861fc5cc0b9b266b439836763ecee3fa9ae4506f

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

Lighthouse URL: https://exponentcms.lighthouseapp.com/projects/61783/tickets/816